This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Multiselect toolbar no longer shows in single select mode #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blackbaud-AlexKingman
requested a review
from Blackbaud-SteveBrush
as a code owner
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
==========================================
+ Coverage 99.53% 99.53% +<.01%
==========================================
Files 12 12
Lines 213 214 +1
Branches 39 41 +2
==========================================
+ Hits 212 213 +1
Misses 1 1
Continue to review full report at Codecov.
|
src/app/public/modules/list-view-checklist/list-view-checklist.component.ts
Outdated
Show resolved
Hide resolved
src/app/public/modules/list-view-checklist/list-view-checklist.component.ts
Outdated
Show resolved
Hide resolved
src/app/public/modules/list-view-checklist/list-view-checklist.component.ts
Outdated
Show resolved
Hide resolved
Blackbaud-SteveBrush
approved these changes
Apr 12, 2019
Blackbaud-AlexKingman
deleted the
single-select-mode-fix-for-multiselect-toolbar
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #29
This only happened if
selectModewas set tosingleinitially. Also cleaned up the tests a bit, and added a test to cover this scenario.