-
Notifications
You must be signed in to change notification settings - Fork 2
Fixed issues around the data providers being called too many times. #20
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20 +/- ##
==========================================
+ Coverage 99.68% 99.69% +0.01%
==========================================
Files 18 18
Lines 314 330 +16
Branches 38 42 +4
==========================================
+ Hits 313 329 +16
Misses 1 1
Continue to review full report at Codecov.
|
src/app/public/modules/list-view-grid/list-view-grid.component.ts
Outdated
Show resolved
Hide resolved
src/app/public/modules/list-view-grid/list-view-grid.component.ts
Outdated
Show resolved
Hide resolved
src/app/public/modules/list-view-grid/list-view-grid.component.ts
Outdated
Show resolved
Hide resolved
src/app/public/modules/list-view-grid/list-view-grid.component.ts
Outdated
Show resolved
Hide resolved
@Blackbaud-TrevorBurch Is there an issue or detailed description we can add to the pull request to better explain the need for these changes? |
@Blackbaud-SteveBrush https://github.com/blackbaud/skyux-list-builder/issues/12 I had linked it through Zenhub but didn't put it in the description. There are two issues being fixed here in reality.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for tracking this down.
@Blackbaud-SteveBrush I added some unit tests for these changes |
No description provided.