This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Added multiselect support #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blackbaud-AlexKingman
requested a review
from Blackbaud-SteveBrush
as a code owner
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
==========================================
+ Coverage 99.69% 99.72% +0.03%
==========================================
Files 18 18
Lines 329 368 +39
Branches 41 47 +6
==========================================
+ Hits 328 367 +39
Misses 1 1
Continue to review full report at Codecov.
|
Blackbaud-ToddRoberts
previously approved these changes
Jan 31, 2019
Blackbaud-TrevorBurch
previously approved these changes
Jan 31, 2019
|
The build is failing because we need list-builder to merge first. The tests are missing a method. I'll come back around and fix that once list-builder is merged. |
Blackbaud-AlexKingman
dismissed stale reviews from Blackbaud-TrevorBurch and Blackbaud-ToddRoberts
via
53e7740
Blackbaud-TrevorBurch
suggested changes
Mar 20, 2019
src/app/public/modules/list-view-grid/list-view-grid.component.ts
Outdated
Show resolved
Hide resolved
src/app/public/modules/list-view-grid/list-view-grid.component.ts
Outdated
Show resolved
Hide resolved
src/app/public/modules/list-view-grid/list-view-grid.component.ts
Outdated
Show resolved
Hide resolved
src/app/public/modules/list-view-grid/list-view-grid.component.html
Outdated
Show resolved
Hide resolved
src/app/public/modules/list-view-grid/list-view-grid.component.ts
Outdated
Show resolved
Hide resolved
Blackbaud-SteveBrush
approved these changes
Mar 22, 2019
Blackbaud-TrevorBurch
approved these changes
Mar 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #23 and #13.