Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

List toolbar search actions #52

Merged
merged 8 commits into from
Jul 1, 2019
Merged

List toolbar search actions #52

merged 8 commits into from
Jul 1, 2019

Conversation

Blackbaud-SteveBrush
Copy link
Member

@Blackbaud-SteveBrush Blackbaud-SteveBrush commented Jun 28, 2019 •
edited
Loading

@codecov
Copy link

codecov bot commented Jul 1, 2019 •
edited
Loading

Codecov Report

Merging #52 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
+ Coverage   99.54%   99.54%   +<.01%     
==========================================
  Files          94       95       +1     
  Lines        1326     1328       +2     
  Branches      143      143              
==========================================
+ Hits         1320     1322       +2     
  Misses          6        6
Impacted Files Coverage Δ
...public/modules/list-toolbar/list-toolbar.module.ts 100% <100%> (ø) ⬆️
...t-toolbar/list-toolbar-search-actions.component.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2a6e3b...9783075. Read the comment docs.

Blackbaud-ToddRoberts
Blackbaud-ToddRoberts previously approved these changes Jul 1, 2019
View reviewed changes
Copy link

@Blackbaud-ToddRoberts Blackbaud-ToddRoberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Is the plan still to not document this feature since we don't want people using directly except in the select field scenario?

@Blackbaud-SteveBrush
Copy link
Member Author

@Blackbaud-ToddRoberts You are correct: we will not be documenting this feature, officially.

Blackbaud-AlexKingman
Blackbaud-AlexKingman reviewed Jul 1, 2019
View reviewed changes
Copy link
Contributor

@Blackbaud-AlexKingman Blackbaud-AlexKingman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One style comment, then we're all good!

src/app/public/modules/list-toolbar/list-toolbar-search-actions.component.ts Outdated
@@ -1,9 +1,11 @@
import {
Component
Component, ChangeDetectionStrategy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imports need to be on their own lines.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops! Done.

src/app/public/modules/list-toolbar/list-toolbar.component.scss Show resolved Hide resolved
Blackbaud-AlexKingman
Blackbaud-AlexKingman approved these changes Jul 1, 2019
View reviewed changes
Copy link
Contributor

@Blackbaud-AlexKingman Blackbaud-AlexKingman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🇮🇹

@Blackbaud-SteveBrush Blackbaud-SteveBrush merged commit fcb73b6 into master Jul 1, 2019
@Blackbaud-SteveBrush Blackbaud-SteveBrush deleted the list-toolbar-search-actions branch July 1, 2019 20:31
@Blackbaud-SteveBrush Blackbaud-SteveBrush mentioned this pull request Jul 1, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Blackbaud-AlexKingman Blackbaud-AlexKingman Blackbaud-AlexKingman approved these changes

@Blackbaud-ToddRoberts Blackbaud-ToddRoberts Blackbaud-ToddRoberts left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Blackbaud-SteveBrush @Blackbaud-ToddRoberts @Blackbaud-AlexKingman @blackbaud-vimal-kumar