-
Notifications
You must be signed in to change notification settings - Fork 8
Conversation
color: $sky-text-color-default; | ||
padding-left: 6px; | ||
border-left: $sky-nav-selected-border-width solid $sky-highlight-color-info; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report
@@ Coverage Diff @@
## master #51 +/- ##
==========================================
+ Coverage 99.52% 99.57% +0.04%
==========================================
Files 24 24
Lines 424 470 +46
Branches 41 46 +5
==========================================
+ Hits 422 468 +46
Misses 2 2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
styling looks correct to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for the detailed comments; helps a ton when reviewing.
I know the visual demo only allows for one active item at a time, but it's possible to make more than one item active if the consumer wishes. I'm thinking we'd like to avoid that kind of behavior and force the active state to only one of the items?
What if you put an activeItemIndex
on the <sky-repeater>
component instead?
0e086cd
Updated to go off |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One quick comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are a few structural changes that are needed. The repeater items should handle their own registration (and unregistration) with the service in their ngOnInit
and ngOnDestroy
. If we need to talk it through offline, let me know!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better. Great work!
Addresses #43
Style should be similar to vertical tabs:
https://developer.blackbaud.com/skyux/components/vertical-tabs#demo
This class will be used to show which item is active when using in conjunction with split view component.
Docs update needed. Issue filed here: blackbaud/skyux2-docs#575