Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

adding a max-width style to the repeater container #9

Merged
merged 6 commits into from
Dec 17, 2018
Merged

adding a max-width style to the repeater container #9

merged 6 commits into from
Dec 17, 2018

Conversation

Blackbaud-BrandonJones
Copy link
Contributor

@Blackbaud-BrandonJones Blackbaud-BrandonJones commented Dec 5, 2018 •
edited
Loading

blackbaud/skyux2#2232

When there is a long unbroken string, or element within a repeater, it can push the repeater outside of it's parent container's bounds. This was first seen using the stache-code-block, but can be duplicated with the following.

  <sky-repeater expandMode="single">
    <sky-repeater-item [isExpanded]="false">
      <sky-repeater-item-title>Web Config Settings</sky-repeater-item-title>
      <sky-repeater-item-content>
        <p>To run services locally, there are several settings to configure.</p>
          <p>
            https://host.nxt.blackbaud.com/permissions/confirm-invite?envid=0&amp;legalEntityId=1&amp;invitationToken=2&amp;svcid=3safdaslfjahskdg;aslkdgjas;lgdkasdj;glkasdjg;sgdlsjagsdklgj;asgkdjsa;ldgkjas;dlga;sldgkj;aslgjasldgkjs;dlgkajsd;aglkdgjka;slgjdlaskgsgsdafsdg'kas;dlgkjsa;ldkgjsad;lgkdsja;glksjg;dlskagjs;dgdkslgja;sgdjaskd;dgkjg;lsgj;agjld;ksgjas;ljg;ldsgjksaj;l"
          </p>
      </sky-repeater-item-content>
    </sky-repeater-item>
  </sky-repeater>

screen shot 2018-12-17 at 10 38 53 am

@Blackbaud-TrevorBurch
Copy link
Member

Relates to blackbaud/skyux2#2232

Blackbaud-SteveBrush
Blackbaud-SteveBrush reviewed Dec 17, 2018
View reviewed changes
e2e/repeater.e2e-spec.ts Outdated
SkyHostBrowser.setWindowBreakpoint('lg');
SkyHostBrowser.scrollTo('#screenshot-repeater-max-width');
expect('#screenshot-repeater-max-width').toMatchBaselineScreenshot(done, {
screenshotName: 'screenshot-repeater-max-width'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other screenshots start with repeater-. Mind?

screenshotName: 'repeater-max-width'

@Blackbaud-SteveBrush Blackbaud-SteveBrush merged commit b7848ad into blackbaud:master Dec 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Blackbaud-SteveBrush Blackbaud-SteveBrush Blackbaud-SteveBrush approved these changes

@Blackbaud-AlexKingman Blackbaud-AlexKingman Awaiting requested review from Blackbaud-AlexKingman

Assignees

@Blackbaud-BrandonJones Blackbaud-BrandonJones

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Blackbaud-BrandonJones @Blackbaud-TrevorBurch @Blackbaud-SteveBrush