This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
Update adapter to Renderer2 (fixes ngOnInit issues) #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blackbaud-TrevorBurch
requested a review
from Blackbaud-SteveBrush
as a code owner
November 15, 2018 20:01
Blackbaud-SteveBrush
suggested changes
Nov 19, 2018
@Blackbaud-SteveBrush this is ready for another look. I would love to chat around the optional constructor parameters when you have a chance though. I understand the logic but wanted to chat about it to make sure I fully have my head around the consequences there. |
Codecov Report
@@ Coverage Diff @@
## master #13 +/- ##
========================================
+ Coverage 99.77% 100% +0.22%
========================================
Files 21 21
Lines 441 430 -11
Branches 67 64 -3
========================================
- Hits 440 430 -10
+ Misses 1 0 -1
Continue to review full report at Codecov.
|
Blackbaud-SteveBrush
previously requested changes
Nov 28, 2018
Blackbaud-TrevorBurch
dismissed
Blackbaud-SteveBrush’s stale review
December 12, 2018 22:28
New implementation
Blackbaud-SteveBrush
approved these changes
Dec 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.