Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Update adapter to Renderer2 (fixes ngOnInit issues) #13

Merged
merged 12 commits into from
Dec 13, 2018

Conversation

Blackbaud-TrevorBurch
Copy link
Member

No description provided.

@Blackbaud-TrevorBurch
Copy link
Member Author

@Blackbaud-SteveBrush this is ready for another look. I would love to chat around the optional constructor parameters when you have a chance though. I understand the logic but wanted to chat about it to make sure I fully have my head around the consequences there.

@codecov-io
Copy link

codecov-io commented Nov 21, 2018

Codecov Report

Merging #13 into master will increase coverage by 0.22%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #13      +/-   ##
========================================
+ Coverage   99.77%   100%   +0.22%     
========================================
  Files          21     21              
  Lines         441    430      -11     
  Branches       67     64       -3     
========================================
- Hits          440    430      -10     
+ Misses          1      0       -1
Impacted Files Coverage Δ
...c/modules/modal/modal-component-adapter.service.ts 100% <ø> (ø) ⬆️
...pp/public/modules/modal/modal-content.component.ts 100% <100%> (ø) ⬆️
src/app/public/modules/modal/modal.service.ts 100% <100%> (ø) ⬆️
src/app/public/modules/modal/modal.module.ts 100% <100%> (ø) ⬆️
...rc/app/public/modules/modal/modal-configuration.ts 100% <100%> (ø) ⬆️
.../app/public/modules/modal/modal-adapter.service.ts 100% <100%> (+3.44%) ⬆️
...app/public/modules/modal/modal-footer.component.ts 100% <100%> (ø) ⬆️
...app/public/modules/modal/modal-header.component.ts 100% <100%> (ø) ⬆️
...c/app/public/modules/modal/modal-host.component.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2d156d...e41b405. Read the comment docs.

package.json Outdated Show resolved Hide resolved
src/app/public/modules/modal/modal-adapter.service.ts Outdated Show resolved Hide resolved
src/app/public/modules/modal/modal.module.ts Outdated Show resolved Hide resolved
src/app/public/modules/modal/modal.module.ts Outdated Show resolved Hide resolved
src/app/public/modules/modal/modal.service.ts Show resolved Hide resolved
@Blackbaud-TrevorBurch Blackbaud-TrevorBurch merged commit ffdc3ae into master Dec 13, 2018
@Blackbaud-TrevorBurch Blackbaud-TrevorBurch deleted the modal-renderer-upgrade branch December 13, 2018 18:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants