This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Migrate SKY UX 3; fix tests #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #51 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 23 23
Lines 444 453 +9
Branches 67 54 -13
=====================================
+ Hits 444 453 +9
Continue to review full report at Codecov.
|
Blackbaud-TrevorBurch
previously approved these changes
Jun 26, 2019
| @@ -16,27 +16,37 @@ describe('Confirm (lg screen)', () => { | |||
|
|
|||
| it('should match previous OK screenshot', (done) => { | |||
| element(by.css('.sky-confirm-btn-ok')).click(); | |||
| expect('body').toMatchBaselineScreenshot(done); | |||
| expect('body').toMatchBaselineScreenshot(done, { | |||
| screenshotName: 'confirm-ok' | |||
There was a problem hiding this comment.
Thanks for doing this!
Blackbaud-TrevorBurch
dismissed
their stale review
Double checking package lock after merge
Blackbaud-TrevorBurch
approved these changes
Jun 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue(s):
https://github.com/blackbaud/skyux-modals/issues/52
https://github.com/blackbaud/skyux-modals/issues/25
https://github.com/blackbaud/skyux-modals/issues/41