Updated focus style to be more subtle #8
Conversation
blackbaud-conorwright
requested a review
from Blackbaud-SteveBrush
as a code owner
Codecov Report
@@ Coverage Diff @@
## master #8 +/- ##
=======================================
Coverage 99.54% 99.54%
=======================================
Files 21 21
Lines 437 437
Branches 66 66
=======================================
Hits 435 435
Misses 2 2Continue to review full report at Codecov.
|
| @@ -41,6 +41,10 @@ | |||
| .sky-modal-content { | |||
| background-color: #fff; | |||
| z-index: 1; | |||
|
|
|||
| &:focus { | |||
| outline: thin dotted #4d90fe; | |||
There was a problem hiding this comment.
Is this @Blackbaud-ToddRoberts approved?
There was a problem hiding this comment.
It's how I recreated what he suggested ;p
But I haven't received feedback from him on it yet (and he's out until Monday)
There was a problem hiding this comment.
I think it looks generally ok; only slight concern is that if this is across browsers, it will look more prominent than other focus in Firefox where the dotted line is black, but if it has to be the same it's not a showstopper
There was a problem hiding this comment.
Updated to use the browser's color of choice
Resolves: blackbaud/skyux2#2146
Docs: No changes required