This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Fix escape closing modal when focused on dropdown #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blackbaud-JackMcElhinney
requested a review
from Blackbaud-SteveBrush
as a code owner
|
Closing in favor of: blackbaud/skyux-modals#62 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #25
Modal acts on
keydownwhile popovers was waiting for akeyupso when escape was pressed the modal would catch it first before the dropdown could.Switched popovers to act on a
keydownevent instead.Autocomplete seems to be unaffected, as it has its own event handler that acts also on
keydownso now the autocomplete dropdown and normal dropdown should respond to escape in the same way.