Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Add finish button; goto specific step; various bug fixes #17

Merged
merged 10 commits into from
May 13, 2019

Conversation

Blackbaud-SteveBrush
Copy link
Member

@Blackbaud-SteveBrush Blackbaud-SteveBrush commented Apr 22, 2019

@Blackbaud-SteveBrush Blackbaud-SteveBrush changed the title Finish button etc Add finish button; goto specific step; various bug fixes Apr 22, 2019
@codecov
Copy link

codecov bot commented Apr 22, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@20dcf36). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #17   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?     12           
  Lines             ?    394           
  Branches          ?     80           
=======================================
  Hits              ?    394           
  Misses            ?      0           
  Partials          ?      0
Impacted Files Coverage Δ
...-indicator/types/progress-indicator-item-status.ts 100% <100%> (ø)
...utton/progress-indicator-reset-button.component.ts 100% <100%> (ø)
...es/progress-indicator/progress-indicator.module.ts 100% <100%> (ø)
...-button/progress-indicator-nav-button.component.ts 100% <100%> (ø)
...ndicator-item/progress-indicator-item.component.ts 100% <100%> (ø)
...rker/progress-indicator-status-marker.component.ts 100% <100%> (ø)
...progress-indicator/progress-indicator.component.ts 100% <100%> (ø)
...rogress-indicator/types/progress-indicator-mode.ts 100% <100%> (ø)
...indicator/types/progress-indicator-message-type.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20dcf36...2eefdd3. Read the comment docs.

@Blackbaud-SteveBrush Blackbaud-SteveBrush changed the title Add finish button; goto specific step; various bug fixes [HOLD] Add finish button; goto specific step; various bug fixes Apr 30, 2019
@Blackbaud-SteveBrush Blackbaud-SteveBrush changed the title [HOLD] Add finish button; goto specific step; various bug fixes Add finish button; goto specific step; various bug fixes May 1, 2019
@Blackbaud-SteveBrush Blackbaud-SteveBrush changed the title Add finish button; goto specific step; various bug fixes [HOLD] Add finish button; goto specific step; various bug fixes May 3, 2019
@Blackbaud-SteveBrush Blackbaud-SteveBrush changed the title [HOLD] Add finish button; goto specific step; various bug fixes Add finish button; goto specific step; various bug fixes May 6, 2019
Copy link
Contributor

@Blackbaud-AlexKingman Blackbaud-AlexKingman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this. It's a huge improvement & nice style cleanup. See feedback below!

Copy link
Contributor

@Blackbaud-AlexKingman Blackbaud-AlexKingman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of improvements in here. Great job 👍

@Blackbaud-SteveBrush Blackbaud-SteveBrush merged commit 211eb56 into master May 13, 2019
@Blackbaud-SteveBrush Blackbaud-SteveBrush deleted the finish-button-etc branch May 13, 2019 13:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants