This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Add finish button; goto specific step; various bug fixes #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blackbaud-SteveBrush
changed the title
Finish button etc
Add finish button; goto specific step; various bug fixes
Apr 22, 2019
Blackbaud-SteveBrush
requested review from
Blackbaud-AlexKingman and
Blackbaud-TrevorBurch
April 22, 2019 23:54
Blackbaud-SteveBrush
changed the title
Add finish button; goto specific step; various bug fixes
[HOLD] Add finish button; goto specific step; various bug fixes
Apr 30, 2019
Blackbaud-SteveBrush
changed the title
[HOLD] Add finish button; goto specific step; various bug fixes
Add finish button; goto specific step; various bug fixes
May 1, 2019
Blackbaud-SteveBrush
changed the title
Add finish button; goto specific step; various bug fixes
[HOLD] Add finish button; goto specific step; various bug fixes
May 3, 2019
Blackbaud-SteveBrush
changed the title
[HOLD] Add finish button; goto specific step; various bug fixes
Add finish button; goto specific step; various bug fixes
May 6, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this. It's a huge improvement & nice style cleanup. See feedback below!
src/app/visual/progress-indicator/progress-indicator-visual.component.html
Outdated
Show resolved
Hide resolved
src/app/public/modules/progress-indicator/types/progress-indicator-change.ts
Outdated
Show resolved
Hide resolved
src/app/public/modules/progress-indicator/progress-indicator.component.html
Show resolved
Hide resolved
src/app/public/modules/progress-indicator/progress-indicator.component.ts
Outdated
Show resolved
Hide resolved
src/app/public/modules/progress-indicator/progress-indicator.component.ts
Outdated
Show resolved
Hide resolved
...ess-indicator/progress-indicator-reset-button/progress-indicator-reset-button.component.html
Show resolved
Hide resolved
...gress-indicator/progress-indicator-reset-button/progress-indicator-reset-button.component.ts
Show resolved
Hide resolved
...gress-indicator/progress-indicator-reset-button/progress-indicator-reset-button.component.ts
Outdated
Show resolved
Hide resolved
src/app/visual/progress-indicator/progress-indicator-visual.component.html
Show resolved
Hide resolved
src/app/visual/progress-indicator/progress-indicator-visual.component.ts
Show resolved
Hide resolved
Blackbaud-AlexKingman
approved these changes
May 13, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of improvements in here. Great job 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue(s):
https://github.com/blackbaud/skyux-progress-indicator/issues/20
https://github.com/blackbaud/skyux-progress-indicator/issues/16
https://github.com/blackbaud/skyux-progress-indicator/issues/15
https://github.com/blackbaud/skyux-progress-indicator/issues/14
Overview:
SkyProgressIndicatorMessage
.