This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Add SkyProgressIndicatorMessage
#19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blackbaud-SteveBrush
requested review from
Blackbaud-AlexKingman and
Blackbaud-TrevorBurch
Codecov Report
@@ Coverage Diff @@
## master #19 +/- ##
==========================================
+ Coverage 98.67% 99.62% +0.94%
==========================================
Files 10 10
Lines 227 264 +37
Branches 38 46 +8
==========================================
+ Hits 224 263 +39
+ Misses 3 1 -2
Continue to review full report at Codecov.
|
src/app/public/modules/progress-indicator/progress-indicator.component.ts
Show resolved
Hide resolved
src/app/public/modules/progress-indicator/progress-indicator.component.ts
Outdated
Show resolved
Hide resolved
.../modules/progress-indicator/progress-indicator-title/progress-indicator-title.component.html
Show resolved
Hide resolved
| fixture.detectChanges(); | ||
|
|
||
| expect(componentInstance.activeIndex).toBe(3); | ||
| expect(componentInstance.progressItems.last.isActive).toBeFalsy(); |
There was a problem hiding this comment.
I'm confused... How did this test pass before?
There was a problem hiding this comment.
It passed because the logic of the steps was incorrect. The final step has an index of 2 because there's only three items. The final step should also be marked as active. Let me know if I'm missing something obvious!
src/app/public/modules/progress-indicator/progress-indicator.component.ts
Show resolved
Hide resolved
Blackbaud-AlexKingman
approved these changes
May 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.