-
Notifications
You must be signed in to change notification settings - Fork 6
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@blackbaud-conorwright got one comment for you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@blackbaud-conorwright this hooks to where we fire "blur" on "touch". In the datepicker we fire "touch" on "blur" of the input. I'm concerned that with this implementation we will fire the "blur" event on initial touch and not on actually blurring the component. Have we verified this?
Hmm, that's true. This could be a good reason to rename the event to something like |
^ @Blackbaud-TrevorBurch |
Codecov Report
@@ Coverage Diff @@
## master #11 +/- ##
==========================================
+ Coverage 99.43% 99.47% +0.03%
==========================================
Files 6 6
Lines 178 190 +12
Branches 24 26 +2
==========================================
+ Hits 177 189 +12
Partials 1 1
Continue to review full report at Codecov.
|
@blackbaud-conorwright sounds good to me. I should go with |
@Blackbaud-SteveBrush and @Blackbaud-TrevorBurch I've updated the name to be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question
@Blackbaud-TrevorBurch and @Blackbaud-SteveBrush I've updated this to be a "true touch" blur event |
src/app/public/modules/select-field/select-field.component.html
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @Blackbaud-TrevorBurch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two very minor things.
src/app/public/modules/select-field/fixtures/select-field.component.fixture.html
Outdated
Show resolved
Hide resolved
src/app/public/modules/select-field/select-field.component.spec.ts
Outdated
Show resolved
Hide resolved
@Blackbaud-TrevorBurch I believe I've resolved both comments 👍 |
and @Blackbaud-SteveBrush Your review was dismissed by my last commit ;p |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue: #10
Docs: blackbaud/skyux2-docs#228
I expect there may be some concerns about the name
blur
and I can change it. I felt that it is what that event means and this component doesn't have it, so it seemed right. But I also realize that we may just want to completely avoid "reserved" event names.