Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Fixed stylings around invalid select fields #3

Merged
merged 4 commits into from
Nov 28, 2018

Conversation

Blackbaud-TrevorBurch
Copy link
Member

@Blackbaud-TrevorBurch Blackbaud-TrevorBurch commented Nov 14, 2018

@Blackbaud-TrevorBurch
Copy link
Member Author

@Blackbaud-ToddRoberts this will fix the Sky Select Field component

@codecov-io
Copy link

codecov-io commented Nov 14, 2018

Codecov Report

Merging #3 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #3      +/-   ##
==========================================
+ Coverage   99.43%   99.43%   +<.01%     
==========================================
  Files           6        6              
  Lines         177      178       +1     
  Branches       24       24              
==========================================
+ Hits          176      177       +1     
  Partials        1        1
Impacted Files Coverage Δ
...lic/modules/select-field/select-field.component.ts 98.94% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ec5479...c0aea83. Read the comment docs.

@Blackbaud-AlexKingman Blackbaud-AlexKingman self-assigned this Nov 15, 2018
Copy link
Contributor

@Blackbaud-AlexKingman Blackbaud-AlexKingman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Blackbaud-TrevorBurch These changes are just for the visual demo. I was expecting to see some styles for the .ng-invalid state. Am I missing something?

@Blackbaud-TrevorBurch
Copy link
Member Author

@Blackbaud-AlexKingman I think I accidentally committed the wrong file. One second

@Blackbaud-TrevorBurch
Copy link
Member Author

@Blackbaud-AlexKingman Fixed. Sorry about that. I think I clicked the wrong scss file when staging things.

Copy link
Contributor

@Blackbaud-AlexKingman Blackbaud-AlexKingman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy fix. Looks good. Let's make a future work item to take care of some visual tests around invalid states.

Copy link
Member

@Blackbaud-SteveBrush Blackbaud-SteveBrush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get a visual test to demonstrate this working.

@Blackbaud-SteveBrush Blackbaud-SteveBrush merged commit 1ae6aad into master Nov 28, 2018
@Blackbaud-SteveBrush Blackbaud-SteveBrush deleted the validation-stylings branch November 28, 2018 18:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants