-
Notifications
You must be signed in to change notification settings - Fork 6
Fixed stylings around invalid select fields #3
Conversation
@Blackbaud-ToddRoberts this will fix the Sky Select Field component |
Codecov Report
@@ Coverage Diff @@
## master #3 +/- ##
==========================================
+ Coverage 99.43% 99.43% +<.01%
==========================================
Files 6 6
Lines 177 178 +1
Branches 24 24
==========================================
+ Hits 176 177 +1
Partials 1 1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Blackbaud-TrevorBurch These changes are just for the visual demo. I was expecting to see some styles for the .ng-invalid
state. Am I missing something?
@Blackbaud-AlexKingman I think I accidentally committed the wrong file. One second |
@Blackbaud-AlexKingman Fixed. Sorry about that. I think I clicked the wrong |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Easy fix. Looks good. Let's make a future work item to take care of some visual tests around invalid states.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get a visual test to demonstrate this working.
Addresses: blackbaud/skyux2#2132