This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Fix range inputs #35
Merged
Fix range inputs #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o 33-range-input-styles
…o 33-range-input-styles
Blackbaud-TrevorBurch
requested review from
Blackbaud-AlexKingman and
Blackbaud-SteveBrush
as code owners
Codecov Report
@@ Coverage Diff @@
## master #35 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 2 2
Lines 23 23
Branches 1 1
=====================================
Hits 23 23Continue to review full report at Codecov.
|
Blackbaud-SteveBrush
suggested changes
Nov 1, 2018
package.json
Outdated
| @@ -10,7 +10,8 @@ | |||
| "scripts": { | |||
| "skyux": "skyux", | |||
| "test": "npm run build:dev-bundle && skyux test", | |||
| "test:ci": "npm run build:dev-bundle && skyux test --platform travis --coverage library && npm run build", | |||
| "test:ci": "npm run build:dev-bundle && skyux test --platform travis --coverage library && skyux e2e && npm run build", | |||
There was a problem hiding this comment.
Mind also removing && skyux e2e and the test:visual command?
| constructor( | ||
| private styleLoader: SkyAppStyleLoader | ||
| ) { | ||
| this.styleLoader.loadStyles().then(() => { |
There was a problem hiding this comment.
We need to keep this style loader demo somewhere. You could put it in the inputs-demo.component.ts file.
…blackbaud/skyux-theme into 33-range-input-styles-no-visual
Blackbaud-SteveBrush
approved these changes
Nov 1, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: https://github.com/blackbaud/skyux-theme/issues/33