This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Changed select field error state to on touched for consistency #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blackbaud-TrevorBurch
requested review from
Blackbaud-AlexKingman and
Blackbaud-SteveBrush
as code owners
|
@Blackbaud-ToddRoberts this will fix the default html selects. I will have a separate PR for the Sky Select Field component. |
Blackbaud-AlexKingman
previously approved these changes
Nov 15, 2018
Codecov Report
@@ Coverage Diff @@
## master #38 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 2 2
Lines 23 23
Branches 1 1
=====================================
Hits 23 23Continue to review full report at Codecov.
|
Blackbaud-SteveBrush
previously requested changes
Nov 19, 2018
…o select-error-on-touched
Blackbaud-TrevorBurch
dismissed
Blackbaud-SteveBrush’s stale review
Stale review
|
@Blackbaud-SteveBrush visual test is now in place. |
Blackbaud-SteveBrush
approved these changes
Nov 29, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.