Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Tile help button #14

Merged
merged 6 commits into from
Nov 29, 2018
Merged

Tile help button #14

merged 6 commits into from
Nov 29, 2018

Conversation

Blackbaud-TrevorBurch
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Nov 26, 2018 •
edited
Loading

Codecov Report

Merging #14 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #14   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          15     15           
  Lines         361    367    +6     
  Branches       72     73    +1     
=====================================
+ Hits          361    367    +6
Impacted Files Coverage Δ
...rc/app/public/modules/tiles/tile/tile.component.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6836158...bc9f58d. Read the comment docs.

@blackbaud-johnly blackbaud-johnly mentioned this pull request Nov 27, 2018
Closed
@blackbaud-johnly
Copy link
Contributor

I created blackbaud/skyux2#2186 to document the new properties and event in this PR.

@Blackbaud-SteveBrush
Copy link
Member

@Blackbaud-TrevorBurch Just one comment. Overall looks good.

@Blackbaud-TrevorBurch
Copy link
Member Author

@Blackbaud-ToddRoberts thoughts?

Blackbaud-AlexKingman
Blackbaud-AlexKingman approved these changes Nov 28, 2018
View reviewed changes
Copy link
Contributor

@Blackbaud-AlexKingman Blackbaud-AlexKingman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job.

Blackbaud-ToddRoberts
Blackbaud-ToddRoberts approved these changes Nov 29, 2018
View reviewed changes
Copy link

@Blackbaud-ToddRoberts Blackbaud-ToddRoberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@Blackbaud-SteveBrush Blackbaud-SteveBrush merged commit f651b4a into master Nov 29, 2018
@Blackbaud-SteveBrush Blackbaud-SteveBrush deleted the tile-help-button branch November 29, 2018 17:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Blackbaud-AlexKingman Blackbaud-AlexKingman Blackbaud-AlexKingman approved these changes

@Blackbaud-ToddRoberts Blackbaud-ToddRoberts Blackbaud-ToddRoberts approved these changes

@Blackbaud-SteveBrush Blackbaud-SteveBrush Blackbaud-SteveBrush approved these changes

Assignees

@Blackbaud-AlexKingman Blackbaud-AlexKingman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Blackbaud-TrevorBurch @codecov-io @blackbaud-johnly @Blackbaud-SteveBrush @Blackbaud-ToddRoberts @Blackbaud-AlexKingman @Blackbaud-PaulCrowder