Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Contrib: Fix issue when closing all toasts if no toasts have been opened. #21

Merged
merged 3 commits into from
May 28, 2019

Conversation

Blackbaud-TrevorBurch
Copy link
Member

Original contribution: #20
Thanks @Blackbaud-ChristiSchneider

@codecov
Copy link

codecov bot commented May 24, 2019

Codecov Report

Merging #21 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #21   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines         211    213    +2     
  Branches       22     23    +1     
=====================================
+ Hits          211    213    +2
Impacted Files Coverage Δ
src/app/public/modules/toast/toast.service.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29caad1...4dc26ba. Read the comment docs.

@@ -33,6 +33,7 @@ import {
import {
SkyToastService
} from './toast.service';
import { SkyToasterComponent } from './toaster.component';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code style.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@Blackbaud-TrevorBurch Blackbaud-TrevorBurch merged commit 7430798 into master May 28, 2019
@Blackbaud-TrevorBurch Blackbaud-TrevorBurch deleted the contrib-toast-close-all-bug branch May 28, 2019 14:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants