Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Adopt dynamic component service #6

Merged
merged 5 commits into from
Dec 18, 2018

Conversation

Blackbaud-TrevorBurch
Copy link
Member

No description provided.

package.json Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Dec 17, 2018

Codecov Report

Merging #6 into master will increase coverage by 1.35%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #6      +/-   ##
========================================
+ Coverage   98.64%   100%   +1.35%     
========================================
  Files          12     12              
  Lines         221    206      -15     
  Branches       25     21       -4     
========================================
- Hits          218    206      -12     
+ Misses          3      0       -3
Impacted Files Coverage Δ
.../app/public/modules/toast/toast-adapter.service.ts 100% <ø> (ø) ⬆️
src/app/public/modules/toast/toast.service.ts 100% <100%> (ø) ⬆️
src/app/public/modules/toast/toaster.component.ts 100% <100%> (ø) ⬆️
src/app/public/modules/toast/toast.module.ts 100% <100%> (ø) ⬆️
...ublic/plugin-resources/toast-resources-provider.ts 100% <0%> (+37.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8934245...3c1c48b. Read the comment docs.

@Blackbaud-TrevorBurch
Copy link
Member Author

FYI - the baseline screenshots were wrong when I inspected them. I have removed them in order to correct this so that my tests pass.

Copy link
Member

@Blackbaud-SteveBrush Blackbaud-SteveBrush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor things.

src/app/public/modules/toast/toast-adapter.service.spec.ts Outdated Show resolved Hide resolved
src/app/public/modules/toast/toast-adapter.service.spec.ts Outdated Show resolved Hide resolved
src/app/public/modules/toast/toast.service.spec.ts Outdated Show resolved Hide resolved
@Blackbaud-TrevorBurch Blackbaud-TrevorBurch merged commit 74c19c6 into master Dec 18, 2018
@Blackbaud-TrevorBurch Blackbaud-TrevorBurch deleted the adopt-dynamic-component-service branch December 18, 2018 15:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants