This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Adopt dynamic component service #6
Merged
Blackbaud-TrevorBurch
merged 5 commits into
master
from
adopt-dynamic-component-service
Dec 18, 2018
Merged
Adopt dynamic component service #6
Blackbaud-TrevorBurch
merged 5 commits into
master
from
adopt-dynamic-component-service
Dec 18, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blackbaud-TrevorBurch
requested a review
from Blackbaud-SteveBrush
as a code owner
December 13, 2018 19:00
Codecov Report
@@ Coverage Diff @@
## master #6 +/- ##
========================================
+ Coverage 98.64% 100% +1.35%
========================================
Files 12 12
Lines 221 206 -15
Branches 25 21 -4
========================================
- Hits 218 206 -12
+ Misses 3 0 -3
Continue to review full report at Codecov.
|
FYI - the baseline screenshots were wrong when I inspected them. I have removed them in order to correct this so that my tests pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor things.
Blackbaud-SteveBrush
approved these changes
Dec 18, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.