Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Mocked out all services and components in toast service spec #9

Merged
merged 4 commits into from
Dec 20, 2018

Conversation

Blackbaud-SteveBrush
Copy link
Member

Hey @Blackbaud-TrevorBurch your changes worked, but I went ahead and mocked out everything for the service spec, since that's the recommended pattern for Angular service unit tests.

@Blackbaud-SteveBrush Blackbaud-SteveBrush changed the base branch from core-upgrade-release-3.0.0-rc.4 to master December 20, 2018 19:48
@codecov-io
Copy link

Codecov Report

Merging #9 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #9   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines         206    208    +2     
  Branches       21     22    +1     
=====================================
+ Hits          206    208    +2
Impacted Files Coverage Δ
src/app/public/modules/toast/toast.service.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 309979d...f1d144a. Read the comment docs.

Copy link
Member

@Blackbaud-TrevorBurch Blackbaud-TrevorBurch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Blackbaud-SteveBrush Blackbaud-SteveBrush merged commit 577fe87 into master Dec 20, 2018
@Blackbaud-SteveBrush Blackbaud-SteveBrush deleted the toast-service-spec branch December 20, 2018 20:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants