This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Feature/validatorfns #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blackbaud-MatthewMiles
requested a review
from Blackbaud-SteveBrush
as a code owner
|
@Blackbaud-SteveBrush I took a structural approach similar to Angular validators where they are all contained within one class, so that referencing should be as simple as |
|
Hey, @Blackbaud-MatthewMiles thanks for this PR. Just wanted to let you know this is still on our radar and we'll most likely get to it next week. Is that ok for your timeline? Thanks. |
Blackbaud-SteveBrush
approved these changes
Jun 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #11
Docs: Need to be updated to surface these
SkyValidatorsstatic functions so that they can be used within consumers' form controls.