Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(components/layout): add harnesses for toolbar #3001

Open
wants to merge 2 commits into
base: 11.x.x
Choose a base branch
from
Open

feat(components/layout): add harnesses for toolbar #3001

wants to merge 2 commits into from

Conversation

Blackbaud-CoreyArcher
Copy link
Contributor

@Blackbaud-CoreyArcher Blackbaud-CoreyArcher commented Jan 8, 2025 •
edited by azure-boards bot
Loading

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jan 8, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 08d2a6a.

Command Status Duration Result
nx affected --target lint test posttest --confi... ✅ Succeeded 1m 8s View ↗
nx affected --target build lint test posttest -... ✅ Succeeded 25s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-10 20:58:14 UTC

@Blackbaud-CoreyArcher Blackbaud-CoreyArcher added the risk level (author): 1 No additional bugs expected from this change label Jan 8, 2025
@blackbaud-sky-build-user
Copy link
Collaborator

Storybook preview

Component Storybooks:

Apps:

Blackbaud-SandhyaRajasabeson
Blackbaud-SandhyaRajasabeson reviewed Jan 10, 2025
View reviewed changes
libs/components/layout/testing/src/modules/toolbar/toolbar-harness.ts Outdated
/**
* Whether the toolbar has sections or not.
*/
public async hasSections(): Promise<boolean> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont think this is a necessary function for consumers? if they attempt to get sections and there arent any, then we still fail gracefully

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Blackbaud-SandhyaRajasabeson Blackbaud-SandhyaRajasabeson Blackbaud-SandhyaRajasabeson left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@Blackbaud-SandhyaRajasabeson Blackbaud-SandhyaRajasabeson

Labels
risk level (author): 1 No additional bugs expected from this change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Blackbaud-CoreyArcher @blackbaud-sky-build-user @Blackbaud-SandhyaRajasabeson