This repository has been archived by the owner on Jun 22, 2023. It is now read-only.
added ariaLabel to properties #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blackbaud-DeniseCisneros
requested review from
blackbaud-johnly and
Blackbaud-SteveBrush
src/app/components/wait/index.html
Outdated
| propertyName="ariaLabel" | ||
| isOptional="true" | ||
| > | ||
| Defines a string value to label the wait component and the element or page being waited on for accessibility. |
There was a problem hiding this comment.
I don't think this labels "the element or page being waited on." I think it just labels the spinning wait icon so that users with disabilities know that the page is loading. But I'd defer to @Blackbaud-SteveBrush to confirm. ... If I'm right, I think we should tweak this just a bit to be something like:
"Defines a string value to label the wait icon for accessibility while an element or page loads."
Is that right, @Blackbaud-SteveBrush?
There was a problem hiding this comment.
That's correct, @blackbaud-johnly . The ARIA attributes are being applied to the wait component directly.
There was a problem hiding this comment.
Thanks, Steve! I'll edit that line to go with John's wording.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
John, feel free to English me on that line, and Steve, keep me honest, please. :)