This repository has been archived by the owner on Jun 22, 2023. It is now read-only.
Fix showHelp default. Make showSettings match description #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackbaud-johnly
approved these changes
Jan 9, 2019
blackbaud-johnly
added a commit
that referenced
this pull request
Feb 15, 2019
* design resources + oct update (#176) @Blackbaud-AdamFunderburk reviewed * Added library as an option for skyux new (#175) * Added library as an option for skyux new * Updated per John's feedback * Removing warnings about node/npm versions. (#172) * Removing warnings about node/npm versions. * Minor wording tweak * Update index.html * Using a param setter to accommodate changes. (#177) * Using a param setter to accommodate changes. * Wording tweak * nov update (#178) * nov update * Update index.html * Update index.html deleted a . * Document tile help button property and event (#179) * Document tile help button property and event * Update showHelp and showSettings descriptions * Update numeric component docs (#174) * Update numeric docs and NPM prereq info * Undo changes to prereqs * Update minDigits description * Document settingsKey property for tiles (#180) * Document settingsKey property for tiles * Update index.html * Update index.html (#184) * Add note linking to SKY UX 1 (#185) * Add note linking to SKY UX 1 * Update index.html * Autocomplete/lookup debounce time and search filters updates (#181) * Updates for debounce time and search filters on the autocomplete and lookup components. * Doc tweaks to autocomplete and lookup updates * Update description of autocomplete data property (#187) * Added beforeClose event to modal docs (#188) * added before close docs to modals * added differences back * fixed spacing * Wording tweaks * dec ux update (#189) * Update CLI reference docs (#192) * Update CLI reference docs * Update install description to address feedback. * Update index.html * fix showHelp default. Make showSettings match (#193) * Grid guidelines (#183) * Initial UX guidelines * images + cleanup * Update grid component docs * Update docs * move anatomy section up * edits * updated annotated * don't use multiselect in tiles * Add sky list view grid info and enforce alphabetic order * responsiveness suggestion * Update index.html * Updating text color values (#191) * updating text color values * update typography docs * update skyux version * Document the `sky-fluid-grid` component (#198) * Document the `sky-fluid-grid` component * Update index.html * Added package names to components (#190) * Document selectedColorApplied event on Colorpicker (#197) * Initial changes * Update index.html * Dropdown disabled property for datepicker, dropdown, and timepicker (#199) * Update dropdown, datepicker, and timepicker * Update datepicker, timepicker, and dropdown * Update index.html * Update index.html * Fixed default value for list toolbar search. (#202) * Action button permalink docs (#210) * added permalink docs * fix sentence fragment * Additional doc tweaks * edited demo text to align with SCD team guidelines (#208) * Flyout > Added iterator language to docs (#196) * added iterator language to docs * removed primaryaction * Flyout docs tweaks (#204) * Flyout docs tweaks * Update index.html * Added the `rowHighlightedId` property for both grid types (#209) * Added the `rowHighlightedId` property to both the Grid and List View Grid docs * Added mention of typical use for the highlight property * Doc tweaks * Added test properties for skyuxconfig reference (#212) * Added test properties for skyuxconfig reference * Minor doc tweaks * Added information about tile selector requirements (#214) * Added information about tile selector requirements * Add missing comma * Reworked sub components and added new properties (#213) * reworked subcomponents.Added replaceTitle&replaceDescription * Doc tweaks * Repeater updates (#216) * added isExpanded property * added default value * added footer * added missing properties * Doc tweaks * Document the ListItemModel object on list filters (#211) * Document the ListItemModel object on list filters * Doc tweaks * Update index.html * Mark `data` property as optional * Added message stream properties to popover (#201) * Added message stream properties to popover * Fixed ordering of message types * Wording change to match change being made to dropdown * Doc tweaks * update sky version (#220) * Document settingsKey for grids (#218) * Using svcid. (#221) * Using svcid. * Delete skyuxconfig.serve.json * Documentation for the generate command's force option (#207) * Documentation for the generate command's force option * Add missing comma and tighten up second sentence * Document pipelineSettings property (#217) * Document pipelineSettings property * Update index.html * Added link to Stache. Re-added link to SKY UX 1. (#222) * Added link to Stache. Re-added link to SKY UX 1. * Incorporate feedback * Minor doc tweak * Tile Dashboard service methods (#215) * added documentation for some public methods of the tile dashboard service * Various tile doc tweaks * Update configuration docs * Create alert to address feedback. * Icon component docs (#205) * added icon component docs * Doc updates for icon component * jan update (#225) * Summary action bar (#182) * Initial docs setup * Add images to summary action bar guidelines * minor tweaks added some text for collapsing the summary info, and changed screenshot type class on a few images. * More summary action bar docs * edits * anatomy layout tweak * moving note about tiles to grid docs * Summary action bar demo (#194) * Updated summary action bar docs to include demo and updated repo to check both locally and sky 2 for demo code contents * Reversed order of looking for demo code content * Fixed build * Fixed import that were not removed when duplicating logic of another file. * rearranged ux content * Flesh out intro, add setup note, and tweak demo buttons * Unhide link to summary action bar docs * Updated version of node * rearranging grid page * Removing node upgrade * Updated to full release * Rework the tab index property (#206) * Rework the tab index property * Additional doc tweaks * Fix install path (#230) * Fix install path * Fix for real this time * Fix typo (#229) * Radio button and Checkbox docs updates (#200) * updated label; Populated checkbox page * Update index.html * Added group tabIndex explanation * Checkbox and radio button doc tweaks * More doc tweaks * More doc tweaks * Final doc tweaks * Update svcid and envid guidance to be more generic (#119) * Update svcid and envid guidance to be more generic * Update params docs * Remove duplicate section * Add param topic and links and make doc tweaks * Move code sample * Added section form service methods (#203) * added service methods * Doc tweaks * Confirm service doc updates (#224) * Confirm service doc updates * Address feedback * Add page anchors to configuration reference (#233) * added vertical tab properties and alphabetized them (#227) * added vertical tab properties and alphabetized them * edited with John's feedback * moved a couple properties to sectioned form * updated with missing edits * Capitalize v in defaultValue * fixed property names * fixed property name * fixing the typo I fat-fingered * Reorganized the contribute section. (#226) * Reorganized the contribute section. * Added a few more repos. * Added/removed some packages (#234) * Added Denise as contributor; moved contributors back to main page (#235) * Doc tweaks (#237) * Doc tweaks * Titles * Removed double space * added note about required and excludeFromRequest (#232) * added note about required and excludeFromRequest * updated with Bobby's feedback * Fixed bad merge of a11y section. Split properties from default params. (#238) * Removed extra < (#240) * cleanup based on John's feedback (#239) * cleanup based on John's feedback * Captialization tweak * Add missing properties and fix defaults * Removew showTabRightArrow property * Document coverage flag (#241) * Document coverage flag * Document coverage flag * Update flag * Adjust indent on new config docs (#245) * Document help button (#242) * Update page title guidance and docs cleanup (#244) * Update page title guidance and docs cleanup * Address feedback from Todd
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: blackbaud/skyux2#2253