Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

sky-repeater-item-title causes doubled up top spacing #1918

Closed
Blackbaud-ToddRoberts opened this issue Aug 16, 2018 · 2 comments
Closed

sky-repeater-item-title causes doubled up top spacing #1918

Blackbaud-ToddRoberts opened this issue Aug 16, 2018 · 2 comments

Comments

@Blackbaud-ToddRoberts
Copy link
Contributor

Expected behavior

sky-repeater-item contains 10px padding, thus the header row content should be 10px from the top.

Actual behavior

sky-repeater-item-title also has 10px top margin, so the header row content is 20px from the top. This top margin on the title should be removed.

@Blackbaud-TrevorBurch
Copy link
Member

@Blackbaud-ToddRoberts the sky-repeater-item-title has both a top and a bottom margin of 10px. Should the bottom margin be retained or also removed?

@Blackbaud-ToddRoberts
Copy link
Contributor Author

I think we should remove the bottom as well, but then add 10px top margin to sky-repeater-item-content assuming that if there is nothing in repeater item content the margin won't show up - that would ensure the correct 10px margin between the header and whatever was below it, whether it's repeater item content or the row divider.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants