This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 65
Changes to fix issues with the spacing for repeaters #1925
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1925 +/- ##
======================================
Coverage 100% 100%
======================================
Files 424 424
Lines 8975 8975
Branches 1327 1327
======================================
Hits 8975 8975 Continue to review full report at Codecov.
|
Blackbaud-TrevorBurch
added
Status: Ready for review
and removed
Status: On hold
labels
Aug 21, 2018
Resolves #1918 |
What if we added a CSS declaration to:
And then removed all margins from h1? Would that do it with less code? |
Blackbaud-AlexKingman
assigned Blackbaud-TrevorBurch and unassigned Blackbaud-AlexKingman
Aug 29, 2018
Blackbaud-TrevorBurch
assigned Blackbaud-TrevorBurch and Blackbaud-AlexKingman and unassigned Blackbaud-TrevorBurch
Aug 29, 2018
Blackbaud-AlexKingman
approved these changes
Aug 29, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 🇮🇹
Blackbaud-AlexKingman
added
Status: Ready to merge
and removed
Status: Ready for review
labels
Aug 29, 2018
Blackbaud-AlexKingman
assigned Blackbaud-TrevorBurch and unassigned Blackbaud-AlexKingman
Aug 29, 2018
@Blackbaud-ToddRoberts you mentioned on Slack that you were having another designer check this. I'll wait on you to give me the green light before I merge this. |
Spacing looks good. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.