Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Changes to fix issues with the spacing for repeaters #1925

Merged
merged 12 commits into from
Sep 6, 2018

Conversation

Blackbaud-TrevorBurch
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Aug 21, 2018

Codecov Report

Merging #1925 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1925   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files         424     424           
  Lines        8975    8975           
  Branches     1327    1327           
======================================
  Hits         8975    8975

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62de28b...6c02813. Read the comment docs.

@Blackbaud-AlexKingman Blackbaud-AlexKingman self-assigned this Aug 29, 2018
@Blackbaud-TrevorBurch
Copy link
Member Author

Resolves #1918

@Blackbaud-AlexKingman
Copy link
Contributor

What if we added a CSS declaration to:

sky-repeater-item-content {
    display: block;
    margin: 10px 0 0;
}

And then removed all margins from h1? Would that do it with less code?

Copy link
Contributor

@Blackbaud-AlexKingman Blackbaud-AlexKingman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🇮🇹

@Blackbaud-TrevorBurch
Copy link
Member Author

@Blackbaud-ToddRoberts you mentioned on Slack that you were having another designer check this. I'll wait on you to give me the green light before I merge this.

@Blackbaud-ToddRoberts
Copy link
Contributor

Spacing looks good.

@Blackbaud-TrevorBurch Blackbaud-TrevorBurch merged commit 56e46c1 into master Sep 6, 2018
@Blackbaud-TrevorBurch Blackbaud-TrevorBurch deleted the 1918-repeater-spacing-fixes branch September 6, 2018 15:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants