Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Tile change detection does not happen when component hosting tile dashboard uses OnPush #324

Closed
Blackbaud-PaulCrowder opened this issue Feb 1, 2017 · 0 comments
Assignees

Comments

@Blackbaud-PaulCrowder
Copy link
Member

Expected behavior

Using ChangeDetectionStrategy.OnPush on a component that contains a tile dashboard should have the tiles on the tile dashboard be rendered when the dashboard's config property is set.

Actual behavior

Tiles are not rendered properly until change detection triggered by some other event on the tile.

Steps to reproduce

  • Create a component that hosts a sky-tile-dashboard.
  • Set its changeDetection property to ChangeDetectionStrategy.OnPush.
  • Set the tile dashboard's config to display tiles.
  • Notice that portions of the tile that are bound to a property on the controller are not displayed (you can see this in the provided Plunker where the first tile's title is not rendered and the second tile is not collapsed).

Plunker

https://plnkr.co/edit/r3foEngqmxSnazESG7gy?p=preview

@Blackbaud-PaulCrowder Blackbaud-PaulCrowder self-assigned this Feb 1, 2017
Blackbaud-PaulCrowder added a commit that referenced this issue Feb 1, 2017
Blackbaud-PaulCrowder added a commit that referenced this issue Feb 1, 2017
…ush change detection strategy (#325)

* Fixed bug where tile was not rendered properly when a parent used OnPush change detection strategy

Fixes #324

* Improved expect messages.

* Fixed unit tests.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant