Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Sky Grid Columns created with ngFor do not update if model is updated #339

Closed
Blackbaud-TrevorBurch opened this issue Feb 7, 2017 · 1 comment
Assignees

Comments

@Blackbaud-TrevorBurch
Copy link
Member

Expected behavior

When creating sky-grid-column elements using an ngFor I would expect the available columns to update if the list of columns updates.

Actual behavior

If the available columns provided to the ngFor changes the sky-grid does not update to reflect these changes. This causes trying to populate a list of available columns using an HTTP call difficult as the grid does not update with the available columns once the HTTP data is returned.

Steps to reproduce

Create a sky grid and use an ngFor to create the sky-grid-column elements. Have the variable that the ngFor references start with some initial data. In some manner, change the data for this variable and notice that the sky-grid does not update with the new columns.

Plunker

https://plnkr.co/edit/Db0Ly9o3jhlMNlFGYNMG?p=preview

This Plunker shows the issue by showing that if you click the "Change columns" button the paragraph elements change but the sky-grid that references the same data does not change.

Blackbaud-PatrickOFriel added a commit that referenced this issue Feb 13, 2017
TODO:
  - unit tests
Blackbaud-PatrickOFriel added a commit that referenced this issue Feb 17, 2017
* updates for #339

TODO:
  - unit tests

* Add tests for dynamic columns

* add longer wait for search visual test
@Blackbaud-PatrickOFriel
Copy link
Contributor

In 2.0.0-beta.8

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants