Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Modal Tab Behavior Different Than Sky UX 1 #635

Closed
Blackbaud-TrevorBurch opened this issue Apr 27, 2017 · 2 comments
Closed

Modal Tab Behavior Different Than Sky UX 1 #635

Blackbaud-TrevorBurch opened this issue Apr 27, 2017 · 2 comments
Assignees

Comments

@Blackbaud-TrevorBurch
Copy link
Member

Expected behavior

In Sky UX 1 when you tab throughout a modal when it reaches the end of the contents it will tab back up to the top of the modal.

Actual behavior

In Sky UX 2 when you tab to the end of the modal it will tab into the address bar of the browser and then will tab through things behind the modal before it tabs back to the top of the modal

Steps to reproduce

Visible on the respective docs pages for the Sky UX 1 and Sky UX 2 modals.

@Blackbaud-PatrickOFriel
Copy link
Contributor

Here's how the ui-bootstrap modal tab behavior works in SKYUX 1, we should probably do something similar: https://github.com/angular-ui/bootstrap/blob/master/src/modal/modal.js#L370

@Blackbaud-PatrickOFriel
Copy link
Contributor

In 2.0.0-rc.8

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants