Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Modal tab trap #911

Merged
merged 14 commits into from
Jul 21, 2017
Merged

Modal tab trap #911

merged 14 commits into from
Jul 21, 2017

Conversation

Blackbaud-PatrickOFriel
Copy link
Contributor

@Blackbaud-PatrickOFriel Blackbaud-PatrickOFriel commented Jul 19, 2017

Copy link
Contributor

@Blackbaud-ToddRoberts Blackbaud-ToddRoberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to behave properly according to the referenced issues

@codecov-io
Copy link

codecov-io commented Jul 19, 2017

Codecov Report

Merging #911 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #911   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files         301    301           
  Lines        5457   5531   +74     
  Branches      673    698   +25     
=====================================
+ Hits         5457   5531   +74
Impacted Files Coverage Δ
src/modules/modal/modal-configuration.ts 100% <ø> (ø) ⬆️
src/modules/modal/modal-host.component.ts 100% <100%> (ø) ⬆️
src/modules/modal/modal-host.service.ts 100% <100%> (ø) ⬆️
...c/modules/modal/modal-component-adapter.service.ts 100% <100%> (ø) ⬆️
src/modules/modal/modal.component.ts 100% <100%> (ø) ⬆️
src/modules/modal/modal-adapter.service.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9d7001...f7397d3. Read the comment docs.

@Blackbaud-PatrickOFriel Blackbaud-PatrickOFriel merged commit 62cebc0 into master Jul 21, 2017
@Blackbaud-BobbyEarl Blackbaud-BobbyEarl deleted the modal-tab-trap branch August 29, 2017 18:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants