Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

skyux test does not fail build #755

Closed
Blackbaud-SteveBrush opened this issue Jun 2, 2017 · 0 comments
Closed

skyux test does not fail build #755

Blackbaud-SteveBrush opened this issue Jun 2, 2017 · 0 comments
Assignees

Comments

@Blackbaud-SteveBrush
Copy link
Member

Expected behavior

skyux test should fail the build.

Actual behavior

The exit code is always 0. I believe it is related to webpack always being in watch mode: https://github.com/blackbaud/skyux-builder/blob/master/plugin/process-exit-code/index.js#L17

From the Webpack docs: "In webpack-dev-server and webpack-dev-middleware watch mode is enabled by default."

Steps to reproduce

  1. create an obvious tslint error.
  2. skyux test throws exit code 0
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants