Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Modernizing ProcessExitCode plugin #173

Merged
merged 2 commits into from
Jun 7, 2017
Merged

Conversation

Blackbaud-BobbyEarl
Copy link

@Blackbaud-BobbyEarl Blackbaud-BobbyEarl commented Jun 6, 2017

@codecov-io
Copy link

codecov-io commented Jun 6, 2017

Codecov Report

Merging #173 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #173   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          38     38           
  Lines         845    843    -2     
  Branches      113    113           
=====================================
- Hits          845    843    -2
Flag Coverage Δ
#builder 100% <100%> (ø) ⬆️
#runtime 100% <ø> (ø) ⬆️
#srcapp 100% <ø> (ø) ⬆️
Impacted Files Coverage Δ
plugin/process-exit-code/index.js 100% <100%> (ø) ⬆️
config/webpack/common.webpack.config.js 100% <100%> (ø) ⬆️
config/webpack/test.webpack.config.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7e9223...17b1d42. Read the comment docs.

@Blackbaud-BobbyEarl
Copy link
Author

I don't believe my changes have introduced a reduction in code coverage. Since I removed code that was previously covered, there is now a smaller total amount of code, but the amount uncovered stayed the same, meaning a smaller percentage of code is now covered.

@Blackbaud-PaulCrowder Blackbaud-PaulCrowder merged commit 018127d into master Jun 7, 2017
@Blackbaud-PaulCrowder Blackbaud-PaulCrowder deleted the test-exit-code branch June 7, 2017 16:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants