Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Search searchChange event is firing on blur not on text change #958

Closed
Blackbaud-TrevorBurch opened this issue Jul 31, 2017 · 1 comment
Closed

Comments

@Blackbaud-TrevorBurch
Copy link
Member

Expected behavior

I would expect the searchChange event to fire on any change to the search text

Actual behavior

The searchChange event is only firing on blur/unfocus

Steps to reproduce

  1. Go to plunker
  2. Type into the search box and don't hit "Enter"
  3. Notice nothing happens
  4. Unfocus the element
  5. Notice that the results change

Plunker

https://plnkr.co/edit/8LILIa7lFs3b2EfEntQH?p=preview

@Blackbaud-PatrickOFriel
Copy link
Contributor

I think it'll work if this: https://github.com/blackbaud/skyux2/blob/master/src/modules/search/search.component.html#L30 is (ngModelChange) instead of (change)
In angular 2 (change) occurs on blur or enter by default I believe, unlike AngularJS

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants