Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Update search change to occur on ngModel change, not angular change #960

Merged
merged 2 commits into from
Aug 1, 2017

Conversation

Blackbaud-PatrickOFriel
Copy link
Contributor

@Blackbaud-PatrickOFriel Blackbaud-PatrickOFriel commented Jul 31, 2017

@codecov-io
Copy link

codecov-io commented Jul 31, 2017

Codecov Report

Merging #960 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #960   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files         301    301           
  Lines        5526   5528    +2     
  Branches      698    698           
=====================================
+ Hits         5526   5528    +2
Impacted Files Coverage Δ
src/modules/search/search.component.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f39079...84c3034. Read the comment docs.

Copy link
Member

@Blackbaud-TrevorBurch Blackbaud-TrevorBurch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I tested locally and saw the event fire correctly now.

@Blackbaud-PatrickOFriel Blackbaud-PatrickOFriel merged commit a504750 into master Aug 1, 2017
@Blackbaud-BobbyEarl Blackbaud-BobbyEarl deleted the search-change branch August 29, 2017 18:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants