-
Notifications
You must be signed in to change notification settings - Fork 65
Allow for correct text-overflow on list view checklists #1043
Allow for correct text-overflow on list view checklists #1043
Conversation
…e text overflows correctly
Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED Commit: 9b6d3dd (Please note that this is a fully automated comment.) |
Codecov Report
@@ Coverage Diff @@
## master #1043 +/- ##
======================================
Coverage 100% 100%
======================================
Files 308 308
Lines 5603 5603
Branches 710 710
======================================
Hits 5603 5603 Continue to review full report at Codecov.
|
Since we're clipping the descriptions, it would probably be a good idea to have the full description available in the
|
👍 I'll get a change in to do that. Do you want the same to happen for the title. Technically if the title gets to long it is clipped also. |
Good catch! Yes, that'd be great to have as well. |
…umn-selector-description-overflow
…tions per code review request
@Blackbaud-SteveBrush This should be ready for you again. The title attributes have been added. |
Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED Commit: b7e7c64 (Please note that this is a fully automated comment.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect. Thank you!
#1000
This was being caused by the text-overflow and overflow css properties not getting applied to the
div
elements inside the list view checklists. The css was present but not specific enough for it to cascade down to thediv
elements and apply. This fix should remedy that.