Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Allow for correct text-overflow on list view checklists #1043

Conversation

Blackbaud-TrevorBurch
Copy link
Member

#1000

This was being caused by the text-overflow and overflow css properties not getting applied to the div elements inside the list view checklists. The css was present but not specific enough for it to cascade down to the div elements and apply. This fix should remedy that.

@blackbaud-sky-savage
Copy link
Collaborator

Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED

Commit: 9b6d3dd
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/272121003

(Please note that this is a fully automated comment.)

@codecov-io
Copy link

codecov-io commented Sep 5, 2017

Codecov Report

Merging #1043 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1043   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files         308     308           
  Lines        5603    5603           
  Branches      710     710           
======================================
  Hits         5603    5603

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cf8a47...b7e7c64. Read the comment docs.

@Blackbaud-SteveBrush
Copy link
Member

Since we're clipping the descriptions, it would probably be a good idea to have the full description available in the title attribute, so that when a user hovers over it, the description can be read in-full.

[attr.title]="item.description"

https://github.com/Blackbaud-TrevorBurch/skyux2/blob/9b6d3dde4d30d6776b535ac65bcb9a4c96cc183c/src/modules/list-view-checklist/list-view-checklist.component.html#L33

@Blackbaud-TrevorBurch
Copy link
Member Author

👍 I'll get a change in to do that. Do you want the same to happen for the title. Technically if the title gets to long it is clipped also.

@Blackbaud-SteveBrush
Copy link
Member

Good catch! Yes, that'd be great to have as well.

@Blackbaud-TrevorBurch
Copy link
Member Author

@Blackbaud-SteveBrush This should be ready for you again. The title attributes have been added.

@blackbaud-sky-savage
Copy link
Collaborator

Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED

Commit: b7e7c64
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/272992124

(Please note that this is a fully automated comment.)

Copy link
Member

@Blackbaud-SteveBrush Blackbaud-SteveBrush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Thank you!

@Blackbaud-SteveBrush Blackbaud-SteveBrush merged commit 028d04d into blackbaud:master Sep 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants