Adjusted tile styles for small screens #1067
Conversation
Blackbaud-SteveBrush
requested review from
Blackbaud-BobbyEarl and
Blackbaud-ToddRoberts
| @@ -18,7 +18,7 @@ | |||
| } | |||
|
|
|||
| :host /deep/ .sky-tile { | |||
| margin: 0; | |||
| margin-bottom: 0 !important; | |||
There was a problem hiding this comment.
I'm surprised by the !important. I would've anticipated the hierarchy and specificity to be enough.
There was a problem hiding this comment.
Yeah, it wasn't enough. Perhaps Angular/Webpack adjusted how /deep/ operates. I've seen this same issue with some Stache2 components.
| @@ -33,6 +33,7 @@ Thumbs.db | |||
| /bower_components | |||
| npm-debug.log* | |||
| yarn.lock | |||
| package-lock.json | |||
There was a problem hiding this comment.
It's not entirely clear to me looking at the PR in GitHub, is the package-lock.json completely removed? I would've expected removing the file and adding this line to .gitignore to be a two-commit process.
There was a problem hiding this comment.
Codecov Report
@@ Coverage Diff @@
## master #1067 +/- ##
======================================
Coverage 100% 100%
======================================
Files 317 317
Lines 5976 5976
Branches 759 759
======================================
Hits 5976 5976Continue to review full report at Codecov.
|
No description provided.