Vertical tabs border #1140
Vertical tabs border #1140
Conversation
…tical-tabs-border
…tical-tabs-border
Codecov Report
@@ Coverage Diff @@
## master #1140 +/- ##
======================================
Coverage 100% 100%
======================================
Files 355 355
Lines 6578 6578
Branches 842 842
======================================
Hits 6578 6578Continue to review full report at Codecov.
|
| [groupHeading]="group.heading" | ||
| [open]="group.isOpen" | ||
| [disabled]="group.isDisabled" | ||
| <div style="height: 40vh"> |
There was a problem hiding this comment.
Can you provide more information around this inline style?
There was a problem hiding this comment.
I was trying to show it would take up the full height of the parent div.
|
@Blackbaud-ToddRoberts Do you approve?
|
|
@Blackbaud-AdamHickey Something I noticed: it might be appropriate to only show the border on non-mobile screens. |
|
Good catch, the border should be hidden on mobile |
|
@Blackbaud-SteveBrush @Blackbaud-ToddRoberts Updated border to hide on mobile. |
Adding a border between the tabs and the content for #1100