Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Tabset padding #1167

Merged
merged 4 commits into from
Oct 6, 2017
Merged

Tabset padding #1167

merged 4 commits into from
Oct 6, 2017

Conversation

Blackbaud-ToddRoberts
Copy link
Contributor

@codecov-io
Copy link

codecov-io commented Oct 5, 2017

Codecov Report

Merging #1167 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1167   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files         355     355           
  Lines        6592    6592           
  Branches      844     844           
======================================
  Hits         6592    6592

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a982def...82cdf86. Read the comment docs.

@Blackbaud-SteveBrush
Copy link
Member

@Blackbaud-PaulCrowder This branch will add padding to the tab component and requires that we delete some screenshots to allow for the tests to pass. This brings up the question: what constitutes a "visual" breaking change? Would simple adjustments to padding be a candidate for a major release?

@Blackbaud-PaulCrowder
Copy link
Member

It's a good question and one that might have a slightly different answer than with SKY UX 1. With SKY UX 1 we knew of consumers doing visual regression tests that would break if we introduced a visual change, so we tended to bundle visual changes up into one (then minor to indicate a breaking change) release. I don't know that the same situation exists for consumers of SKY UX 2, so I'm OK with making these minor visual changes in minor version updates until we get feedback that it's problematic.

@Blackbaud-SteveBrush Blackbaud-SteveBrush merged commit 1be2303 into master Oct 6, 2017
@Blackbaud-SteveBrush Blackbaud-SteveBrush deleted the tabset-padding branch October 6, 2017 20:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants