Using Builder's typescript configs; fixed modal warning #1216
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1216 +/- ##
======================================
Coverage 100% 100%
======================================
Files 355 355
Lines 6622 6620 -2
Branches 853 853
======================================
- Hits 6622 6620 -2
Continue to review full report at Codecov.
|
Blackbaud-SteveBrush
requested review from
Blackbaud-PaulCrowder and
Blackbaud-BobbyEarl
| initializeToolbar(); | ||
| fixture.detectChanges(); | ||
| tick(); | ||
| it('should show secondary actions when specified', async(() => { |
There was a problem hiding this comment.
These changes are purely tab-related.
| mockDragulaService, | ||
| mockMediaQueryService | ||
| ); | ||
| }()); |
There was a problem hiding this comment.
Using a self-invoking function to avoid having an "unused local":
const dashboardService = new SkyTileDashboardService();
| public isWaiting = false; | ||
|
|
||
| constructor( | ||
| private waitSvc: SkyWaitService) { } |
There was a problem hiding this comment.
This is nit-picky, but could you drop the closing parenthesis to the next line or put it all on one line? It's very common to have empty constructors in TypeScript because of the auto-property features, so this is something that I like to see consolidated to one line when possible.
constructor(
private waitSvc: SkyWaitService
) { }
or
constructor(private waitSvc: SkyWaitService) { }
Addresses: #1217 and #1041
@Blackbaud-PaulCrowder This PR attempts to bring the TypeScript and TSLint configs closer to what Builder uses. Aside from the #1217 bugfix, no features have been changed.