This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Fixed colorpicker input group styles #1245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,13 +1,21 @@ | |||
| <div style="display: inline-block" id="screenshot-colorpicker"> | |||
There was a problem hiding this comment.
This was the reason our visual tests didn't catch the repeating background image.
| .then(() => { | ||
| SkyVisualTest.moveCursorOffScreen(); | ||
| return SkyVisualTest.compareScreenshot({ | ||
| return SkyVisualTest |
There was a problem hiding this comment.
The changes to this file are simply tab-related.
| <sky-colorpicker #colorPickerExample1> | ||
| <input [skyColorpickerInput]="colorPickerExample1" [(ngModel)]="color1" [presetColors]="presetColors1" [initialColor]="selectedColor1" | ||
| [outputFormat]="selectedOutputFormat1" /> | ||
| <input |
There was a problem hiding this comment.
Some tabs cleanup...
Blackbaud-SteveBrush
requested review from
Blackbaud-BobbyEarl and
Blackbaud-PaulCrowder
Blackbaud-BobbyEarl
approved these changes
Oct 31, 2017
Codecov Report
@@ Coverage Diff @@
## master #1245 +/- ##
======================================
Coverage 100% 100%
======================================
Files 355 355
Lines 6620 6620
Branches 853 853
======================================
Hits 6620 6620Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #1243
The input group styles were adjusted, which inadvertently affected the colorpicker.
The visual tests did not pick this up because the wrapping container was set to
display: inline-block, which didn't allow the colorpicker to stretch full-width.