Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Fixed checkbox component, position of hidden input #1256

Merged
merged 3 commits into from
Nov 13, 2017

Conversation

Blackbaud-SteveBrush
Copy link
Member

Addresses: #1219

@codecov-io
Copy link

codecov-io commented Nov 1, 2017

Codecov Report

Merging #1256 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1256   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files         355     355           
  Lines        6635    6635           
  Branches      854     854           
======================================
  Hits         6635    6635

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97a2aae...f9196d0. Read the comment docs.

@Blackbaud-SteveBrush Blackbaud-SteveBrush changed the title Fixed checkbox component position of hidden input Fixed checkbox component, position of hidden input Nov 3, 2017
@Blackbaud-BobbyEarl
Copy link

For some reason, this felt very familiar to me so I searched back through skyux1.

We seemed to have fixed a similar bug in skyux1 via blackbaud/skyux#340 but then later applied a different fix via blackbaud/skyux@4928332#diff-b8edbd343ad0548b0b7464d4d1dc63b1

Is there any similarity here?

@Blackbaud-SteveBrush
Copy link
Member Author

@Blackbaud-BobbyEarl I didn't notice many similarities between the issues you shared (thanks!) and this particular branch. I did test it on the Safari iOS agent to be sure, however.

@Blackbaud-SteveBrush Blackbaud-SteveBrush merged commit 66f12e8 into master Nov 13, 2017
@Blackbaud-SteveBrush Blackbaud-SteveBrush deleted the fix-checkbox-position branch November 13, 2017 17:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants