-
Notifications
You must be signed in to change notification settings - Fork 65
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1350 +/- ##
======================================
Coverage 100% 100%
======================================
Files 370 370
Lines 6796 6788 -8
Branches 874 874
======================================
- Hits 6796 6788 -8
Continue to review full report at Codecov.
|
@Blackbaud-BobbyEarl @Blackbaud-PaulCrowder I'd like to get this merged in before any other pull requests so we can get the docs separated and move on with new features ASAP. |
Is there a way for a developer contributing to the skyux2 repo to create the demo component and run it without having to do anything in the skyux2-docs repo? That would mirror what we had with skyux/skyux-docs. |
]; | ||
} | ||
getCodeFiles: () => this.getDemoFiles('SkyFilterDemoComponent') | ||
.concat(this.getDemoFiles('SkyFilterInlineDemoComponent')) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI the use of the TypeScript spread operator instead of .concat()
might make this code a little more aesthetically pleasing.
getCodeFiles: () => [
...this.getDemoFiles('SkyFilterDemoComponent'),
...this.getDemoFiles('SkyFilterInlineDemoComponent')
]
This branch essentially moves all demo components to an exported Demo module that can be consumed by other SPAs.
How to test:
Clone the docs SPA:
first-release
Build UX components:
npm run build
dist
folder intoskyux2-docs/node_modules/@blackbaud/skyux
skyux build -s
to see the new demo components