Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Demo components module #1350

Merged
merged 15 commits into from
Jan 4, 2018
Merged

Demo components module #1350

merged 15 commits into from
Jan 4, 2018

Conversation

Blackbaud-SteveBrush
Copy link
Member

@Blackbaud-SteveBrush Blackbaud-SteveBrush commented Dec 7, 2017

This branch essentially moves all demo components to an exported Demo module that can be consumed by other SPAs.

  • Eventually, we will remove the documentation from this SPA, and move it elsewhere.

How to test:

Clone the docs SPA:

Build UX components:

  • Type npm run build
  • Copy the dist folder into skyux2-docs/node_modules/@blackbaud/skyux
  • Type skyux build -s to see the new demo components

@codecov-io
Copy link

codecov-io commented Dec 7, 2017

Codecov Report

Merging #1350 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1350   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files         370     370           
  Lines        6796    6788    -8     
  Branches      874     874           
======================================
- Hits         6796    6788    -8
Impacted Files Coverage Δ
...s/link-records/link-records-item-diff.component.ts 100% <ø> (ø) ⬆️
...vertical-tabset/vertical-tabset-group.component.ts 100% <ø> (ø) ⬆️
src/modules/link-records/link-records.component.ts 100% <ø> (ø) ⬆️
src/modules/list/helpers.ts 100% <ø> (ø) ⬆️
...sectioned-form/sectioned-form-section.component.ts 100% <ø> (ø) ⬆️
...provider-in-memory/list-data-in-memory.provider.ts 100% <ø> (ø) ⬆️
src/modules/list/list.component.ts 100% <100%> (ø) ⬆️
...dules/vertical-tabset/vertical-tabset.component.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6ba56c...b80979d. Read the comment docs.

@Blackbaud-SteveBrush
Copy link
Member Author

@Blackbaud-BobbyEarl @Blackbaud-PaulCrowder I'd like to get this merged in before any other pull requests so we can get the docs separated and move on with new features ASAP.

@Blackbaud-PaulCrowder
Copy link
Member

Is there a way for a developer contributing to the skyux2 repo to create the demo component and run it without having to do anything in the skyux2-docs repo? That would mirror what we had with skyux/skyux-docs.

];
}
getCodeFiles: () => this.getDemoFiles('SkyFilterDemoComponent')
.concat(this.getDemoFiles('SkyFilterInlineDemoComponent'))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI the use of the TypeScript spread operator instead of .concat() might make this code a little more aesthetically pleasing.

        getCodeFiles: () => [
          ...this.getDemoFiles('SkyFilterDemoComponent'),
          ...this.getDemoFiles('SkyFilterInlineDemoComponent')
        ]

@Blackbaud-SteveBrush Blackbaud-SteveBrush merged commit bbd4b1d into master Jan 4, 2018
@Blackbaud-SteveBrush Blackbaud-SteveBrush deleted the demo-component-module branch January 4, 2018 20:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants