This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Replace innerText call with textContent #1422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED Commit: f06dd3c (Please note that this is a fully automated comment.) |
Codecov Report
@@ Coverage Diff @@
## master #1422 +/- ##
======================================
Coverage 100% 100%
======================================
Files 370 370
Lines 6789 6789
Branches 874 874
======================================
Hits 6789 6789Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug was encountered when testing a directive within a SkyUX2 SPA where overflow styling was causing certain test to fail. This was determined to be caused by the use of the
innerTextelement property.The
innerTextproperty is only text that is actually rendered on the page whiletextContentis the all text, regardless whether it is rendered.Because the point of unit tests is to test the TypeScript portion of the application and the visual tests determine if the content is correctly rendered, I think this should be pulled to master.