This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Removed OnPush change detection from definition list value component #1424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is so the template will re-evaluate the length of the value’s `innerText` element when changes occur to the parent component. Fixes #967
Codecov Report
@@ Coverage Diff @@
## master #1424 +/- ##
======================================
Coverage 100% 100%
======================================
Files 370 370
Lines 6789 6789
Branches 874 874
======================================
Hits 6789 6789
Continue to review full report at Codecov.
|
Blackbaud-PaulCrowder
requested review from
Blackbaud-BobbyEarl and
Blackbaud-SteveBrush
Blackbaud-BobbyEarl
suggested changes
Jan 17, 2018
| @@ -75,6 +79,31 @@ describe('Definition list component', () => { | |||
| expect(defaultValueEl).toHaveText('None found'); | |||
| }); | |||
|
|
|||
| it('should display a susequent value no value is initially specified', () => { | |||
There was a problem hiding this comment.
There are a couple typos in the test name.
Blackbaud-BobbyEarl
approved these changes
Jan 22, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is so the template will re-evaluate the length of the value’s
innerTextelement when changes occur to the parent component.Fixes #967