This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Fixed action button keyup also triggering click event #1448
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #994
The
keyup
event also triggers a click event.When the modal closes, it immediately focuses the trigger element. If the close button was triggered using the enter key, it will fire the
keyup
event on the newly focused trigger button. To avoid this behavior, we can instead registerkeydown
on the action button, to prevent the close button'skeyup
from also being triggered.To test, add an action button to the modal demo component and serve.