Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Allow for async popover refs #1475

Merged
merged 2 commits into from
Feb 15, 2018
Merged

Conversation

Blackbaud-SteveBrush
Copy link
Member

I updated the demo component to show the use case for this: if theskyPopover reference doesn't exist on the DOM, it throws an error. This pull request should allow for asynchronous references.

#1473

@codecov-io
Copy link

codecov-io commented Feb 14, 2018

Codecov Report

Merging #1475 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1475   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files         383     383           
  Lines        7416    7440   +24     
  Branches      948     951    +3     
======================================
+ Hits         7416    7440   +24
Impacted Files Coverage Δ
src/modules/popover/popover.directive.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1625b1a...ad48f79. Read the comment docs.

@Blackbaud-SteveBrush Blackbaud-SteveBrush merged commit e65b196 into master Feb 15, 2018
@Blackbaud-SteveBrush Blackbaud-SteveBrush deleted the fix-async-popovers branch February 15, 2018 17:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants