Resolving Card action bar still visable after hiding with *ngIf #1421 #1533
Conversation
|
Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED Commit: 3f4222e (Please note that this is a fully automated comment.) |
| @@ -2,6 +2,7 @@ import { Component } from '@angular/core'; | |||
|
|
|||
| @Component({ | |||
| selector: 'sky-card-actions', | |||
| styleUrls: ['./card-actions.component.scss'], | |||
There was a problem hiding this comment.
I know these are in alphabetical order, but our convention is to put styleUrls after templateUrl. :)
| @import "../../scss/mixins"; | ||
|
|
||
| :host { | ||
| display: block; |
There was a problem hiding this comment.
Two-spaced tabs, please! (We need to figure out how to enforce this on a configuration level...)
|
Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED Commit: a450054 (Please note that this is a fully automated comment.) |
Codecov Report
@@ Coverage Diff @@
## master #1533 +/- ##
======================================
Coverage 100% 100%
======================================
Files 387 387
Lines 7568 7568
Branches 970 970
======================================
Hits 7568 7568
Continue to review full report at Codecov.
|
|
Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED Commit: 4b809aa (Please note that this is a fully automated comment.) |
|
Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED Commit: d55f351 (Please note that this is a fully automated comment.) |
Fixed the issue where Card Action Bars are still visible when the Actions are being hidden by *ngIf.
Resolves: #1421