Added resizing functionality to flyout #1539

Blackbaud-StacyCarlos · 2018-03-09T19:51:23Z

Addresses #1459

Although this added the functionality to resize the flyout, I would like to address several issues before being pulled

Expected size behavior when below tablet size
Expected behavior when resized smaller/larger than viewport
Should option be toggleable?

… effectively show content.

blackbaud-sky-savage · 2018-03-09T20:39:31Z

Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: b4d3dda
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/351468593

(Please note that this is a fully automated comment.)

blackbaud-sky-savage · 2018-03-09T20:44:58Z

Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: d4ceb93
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/351471794

(Please note that this is a fully automated comment.)

into resize-flyout

…los/skyux2 into resize-flyout

blackbaud-sky-savage · 2018-03-10T15:38:11Z

Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: daacdb9
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/351711747

(Please note that this is a fully automated comment.)

blackbaud-sky-savage · 2018-03-12T14:26:40Z

Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: d43ed8d
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/352353863

(Please note that this is a fully automated comment.)

blackbaud-sky-savage · 2018-03-12T15:41:44Z

Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 7e57801
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/352385059

(Please note that this is a fully automated comment.)

blackbaud-sky-savage · 2018-03-12T19:19:42Z

Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 02c55d3
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/352479905

(Please note that this is a fully automated comment.)

blackbaud-sky-savage · 2018-03-12T20:05:00Z

Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 693da8a
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/352506268

(Please note that this is a fully automated comment.)

blackbaud-sky-savage · 2018-03-12T22:11:35Z

Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 15db034
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/352555566

(Please note that this is a fully automated comment.)

into resize-flyout

codecov-io · 2018-03-13T13:39:59Z

Codecov Report

❗ No coverage uploaded for pull request base (master@1335a59). Click here to learn what that means.
The diff coverage is 100%.

@@           Coverage Diff            @@
##             master   #1539   +/-   ##
========================================
  Coverage          ?    100%           
========================================
  Files             ?     387           
  Lines             ?    7590           
  Branches          ?     975           
========================================
  Hits              ?    7590           
  Misses            ?       0           
  Partials          ?       0

Impacted Files	Coverage Δ
src/modules/flyout/flyout.component.ts	`100% <100%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1335a59...bcde44d. Read the comment docs.

blackbaud-sky-savage · 2018-03-13T14:30:05Z

Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 27cb822
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/352841711

(Please note that this is a fully automated comment.)

blackbaud-sky-savage · 2018-03-13T15:23:09Z

Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 5d475fc
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/352877040

(Please note that this is a fully automated comment.)

Blackbaud-SteveBrush · 2018-03-13T16:57:50Z

src/modules/flyout/flyout.component.scss

@@ -10,23 +10,24 @@
  background-color: #fff;
  border-left: 6px solid $sky-highlight-color-info;
  z-index: $sky-flyout-z-index;
-  overflow: auto;


@Blackbaud-StacyCarlos The feature works great! Could you figure out a way to force the width for mobile views (used to be width: 100% for mobile, and width: 50% for anything larger)? It's immediately obvious when you stretch the width of the flyout and then shrink the browser window down...

Do you mean by default before resizing? If so, yes I can figure that.

I have incorporated styling to maintain 100% width at small sizes.

blackbaud-sky-savage · 2018-03-15T16:30:28Z

Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: acd152f
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/353893637

(Please note that this is a fully automated comment.)

blackbaud-sky-savage · 2018-03-15T17:54:09Z

Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: cbb7ecb
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/353938054

(Please note that this is a fully automated comment.)

Blackbaud-SteveBrush

LGTM. We'll go ahead and merge it into a contribution branch, clean it up, and release ASAP!

blackbaud-sky-savage · 2018-03-15T21:04:37Z

Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: bcde44d
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/354021460

(Please note that this is a fully automated comment.)

Blackbaud-SteveBrush · 2018-03-16T21:16:42Z

@blackbaud-sky-savage retry

Blackbaud-StacyCarlos added 2 commits March 9, 2018 14:46

Added resizing functionality to flyout. Also adapting styling to more…

b4d3dda

… effectively show content.

Merge branch 'master' into resize-flyout

d4ceb93

Blackbaud-StacyCarlos added 3 commits March 10, 2018 09:35

Merge branch 'master' of https://github.com/Blackbaud-StacyCarlos/skyux2

ed5a5cd

into resize-flyout

Test changes and improvements

b4a9ddf

Merge branch 'resize-flyout' of https://github.com/Blackbaud-StacyCar…

daacdb9

…los/skyux2 into resize-flyout

Changes to width testing

d43ed8d

Fixed tests again

7e57801

Uses document events

02c55d3

Syntax changes

693da8a

Fixed makeEvent calls

15db034

Merge branch 'master' of https://github.com/Blackbaud-StacyCarlos/skyux2

27cb822

into resize-flyout

Random commit

5d475fc

Blackbaud-SteveBrush self-requested a review March 13, 2018 16:52

Blackbaud-SteveBrush suggested changes Mar 13, 2018

View reviewed changes

Merge branch 'master' into resize-flyout

acd152f

Blackbaud-StacyCarlos added 2 commits March 15, 2018 12:57

100% width at tablet size and smaller

280f7bb

Remove resize cursor at small size

cbb7ecb

Merge branch 'master' into resize-flyout

bcde44d

Blackbaud-SteveBrush changed the base branch from master to contrib-resize-flyout March 15, 2018 20:24

Blackbaud-SteveBrush approved these changes Mar 15, 2018

View reviewed changes

Blackbaud-SteveBrush merged commit 0d98c00 into blackbaud:contrib-resize-flyout Mar 16, 2018

Blackbaud-SteveBrush mentioned this pull request Mar 27, 2018

Contrib > Added resizing functionality to flyout (#1539) #1566

Merged

Blackbaud-SteveBrush added a commit that referenced this pull request Mar 29, 2018

Contrib > Added resizing functionality to flyout (#1539) (#1566)

9b601b7

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added resizing functionality to flyout #1539

Added resizing functionality to flyout #1539

Blackbaud-StacyCarlos commented Mar 9, 2018 •

edited

Loading

blackbaud-sky-savage commented Mar 9, 2018

blackbaud-sky-savage commented Mar 9, 2018

blackbaud-sky-savage commented Mar 10, 2018

blackbaud-sky-savage commented Mar 12, 2018

blackbaud-sky-savage commented Mar 12, 2018

blackbaud-sky-savage commented Mar 12, 2018

blackbaud-sky-savage commented Mar 12, 2018

blackbaud-sky-savage commented Mar 12, 2018

codecov-io commented Mar 13, 2018 •

edited

Loading

blackbaud-sky-savage commented Mar 13, 2018

blackbaud-sky-savage commented Mar 13, 2018

Blackbaud-SteveBrush Mar 13, 2018 •

edited

Loading

Blackbaud-StacyCarlos Mar 15, 2018

Blackbaud-StacyCarlos Mar 15, 2018

blackbaud-sky-savage commented Mar 15, 2018

blackbaud-sky-savage commented Mar 15, 2018

Blackbaud-SteveBrush left a comment

blackbaud-sky-savage commented Mar 15, 2018

Blackbaud-SteveBrush commented Mar 16, 2018

Added resizing functionality to flyout #1539

Added resizing functionality to flyout #1539

Conversation

Blackbaud-StacyCarlos commented Mar 9, 2018 • edited Loading

blackbaud-sky-savage commented Mar 9, 2018

blackbaud-sky-savage commented Mar 9, 2018

blackbaud-sky-savage commented Mar 10, 2018

blackbaud-sky-savage commented Mar 12, 2018

blackbaud-sky-savage commented Mar 12, 2018

blackbaud-sky-savage commented Mar 12, 2018

blackbaud-sky-savage commented Mar 12, 2018

blackbaud-sky-savage commented Mar 12, 2018

codecov-io commented Mar 13, 2018 • edited Loading

Codecov Report

blackbaud-sky-savage commented Mar 13, 2018

blackbaud-sky-savage commented Mar 13, 2018

Blackbaud-SteveBrush Mar 13, 2018 • edited Loading

Choose a reason for hiding this comment

Blackbaud-StacyCarlos Mar 15, 2018

Choose a reason for hiding this comment

Blackbaud-StacyCarlos Mar 15, 2018

Choose a reason for hiding this comment

blackbaud-sky-savage commented Mar 15, 2018

blackbaud-sky-savage commented Mar 15, 2018

Blackbaud-SteveBrush left a comment

Choose a reason for hiding this comment

blackbaud-sky-savage commented Mar 15, 2018

Blackbaud-SteveBrush commented Mar 16, 2018

Blackbaud-StacyCarlos commented Mar 9, 2018 •

edited

Loading

codecov-io commented Mar 13, 2018 •

edited

Loading

Blackbaud-SteveBrush Mar 13, 2018 •

edited

Loading