Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Tile show settings #1540

Merged

Conversation

blackbaud-conorwright
Copy link
Contributor

Added a new showSettings attribute options to decided whether to show the settings button or not on tile components to fix issue #986 .

Resolves: #986

@codecov-io
Copy link

codecov-io commented Mar 12, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@1335a59). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #1540   +/-   ##
========================================
  Coverage          ?    100%           
========================================
  Files             ?     390           
  Lines             ?    7771           
  Branches          ?    1001           
========================================
  Hits              ?    7771           
  Misses            ?       0           
  Partials          ?       0
Impacted Files Coverage Δ
src/modules/tiles/tile/tile.component.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1335a59...920750d. Read the comment docs.

@blackbaud-sky-savage
Copy link
Collaborator

Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: d548e39
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/352368183

(Please note that this is a fully automated comment.)

@blackbaud-sky-savage
Copy link
Collaborator

Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 9d6d5b5
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/352376861

(Please note that this is a fully automated comment.)

@blackbaud-sky-savage
Copy link
Collaborator

Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: f3feb99
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/353820076

(Please note that this is a fully automated comment.)

@blackbaud-sky-savage
Copy link
Collaborator

Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: eae898b
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/353844737

(Please note that this is a fully automated comment.)

@Blackbaud-SteveBrush
Copy link
Member

We'll need to document this, #1560

Copy link
Member

@Blackbaud-SteveBrush Blackbaud-SteveBrush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blackbaud-sky-savage
Copy link
Collaborator

Tests failed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 920750d
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/354026746

(Please note that this is a fully automated comment.)

@Blackbaud-SteveBrush
Copy link
Member

@blackbaud-sky-savage retry

@blackbaud-sky-savage
Copy link
Collaborator

Tests passed. Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED

Commit: 920750d
Build details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/354518927

(Please note that this is a fully automated comment.)

@Blackbaud-SteveBrush Blackbaud-SteveBrush merged commit 8cb503e into blackbaud:master Mar 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tile: cannot conditionally decide whether the settings button is present
4 participants