Contrib > Select field component #1629
Conversation
…into select-field
…into select-field
Blackbaud-SteveBrush
requested review from
Blackbaud-BobbyEarl and
Blackbaud-PaulCrowder
Codecov Report
@@ Coverage Diff @@
## master #1629 +/- ##
==========================================
+ Coverage 99.98% 99.98% +<.01%
==========================================
Files 391 395 +4
Lines 7889 8069 +180
Branches 1152 1183 +31
==========================================
+ Hits 7888 8068 +180
Misses 1 1
Continue to review full report at Codecov.
|
blackbaud-danbowman
assigned Blackbaud-SteveBrush and Blackbaud-BobbyEarl and unassigned Blackbaud-SteveBrush
There was a problem hiding this comment.
In the reactive form demo, after selecting a favorite color, I get different behavior when clicking the "x" versus tabbing to it then hitting enter.
The disabled select field is still accessible via the keyboard.
In the select field, I like that the "x" is accessible via the keyboard, this is different than the behavior in the sky-list. Just want to make sure that's expected.
| ListItemModel | ||
| } from '../list/state'; | ||
|
|
||
| import { SkyListFilterInlineModel } from '../list-filters/list-filter-inline.model'; |
There was a problem hiding this comment.
I personally like all imports on a separate line, but am OK using a single line if it's one import. In any case, I think we should just be consistent. Down below there are more examples of both implementations.
There was a problem hiding this comment.
For new components I've definitely tried to be consistent with single-file imports vs multi-line barrel imports. Happy to look at some instances where I haven't been consistent, however.
There was a problem hiding this comment.
The clear X should be accessible via keyboard in this case. I believe the reason we don't do it e.g. in Search is that the user can clear the text via backspace/delete, which is not the case with Select Field
|
@Blackbaud-BobbyEarl Good eye catching the close button and tabindex issues; those have been addressed. I reached out to @Blackbaud-ToddRoberts to provide some insight around the tab-able clear button on the single-select search field. |
Original contribution: #1496
Addresses: #155